Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run build + tests on every branch #1423

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Run build + tests on every branch #1423

merged 1 commit into from
Apr 11, 2024

Conversation

alancai98
Copy link
Member

Relevant Issues

  • None

Description

  • PRs targeting v1 branch were not running the build.yml GH Action which runs the gradle build and tests
  • Changes build.yml to run on every branch

Other Information

  • Updated Unreleased Section in CHANGELOG: [NO]

    • No public API changes.

  • Any backward-incompatible changes? [NO]

  • Any new external dependencies? [NO]

  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES]

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alancai98 alancai98 self-assigned this Apr 11, 2024
@github-actions GitHub Actions
Copy link

Conformance comparison report-Cross Engine

Base (legacy) eval +/-
% Passing 92.52% 82.85% -9.67%
✅ Passing 5383 4821 -562
❌ Failing 435 998 563
🔶 Ignored 0 0 0
Total Tests 5818 5819 1
Number passing in both: 4648

Number failing in both: 262

Number passing in legacy engine but fail in eval engine: 736

Number failing in legacy engine but pass in eval engine: 173
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.
173 test(s) were failing in legacy but now pass in eval. Before merging, confirm they are intended to pass.
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-LEGACY

Base (00611ba) d003123 +/-
% Passing 92.52% 92.52% 0.00%
✅ Passing 5383 5383 0
❌ Failing 435 435 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0
Number passing in both: 5383

Number failing in both: 435

Number passing in Base (00611ba) but now fail: 0

Number failing in Base (00611ba) but now pass: 0

Conformance comparison report-Cross Commit-EVAL

Base (00611ba) d003123 +/-
% Passing 82.85% 82.85% 0.00%
✅ Passing 4821 4821 0
❌ Failing 998 998 0
🔶 Ignored 0 0 0
Total Tests 5819 5819 0
Number passing in both: 4821

Number failing in both: 998

Number passing in Base (00611ba) but now fail: 1

Number failing in Base (00611ba) but now pass: 1
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️. The following test(s) were previously passing but now fail:

Click here to see
  • path expression with ambiguous table alias (lowercase), compileOption: LEGACY
The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:
Click here to see
  • path expression with ambiguous table alias (lowercase), compileOption: LEGACY

@alancai98
Copy link
Member Author

for comparison, this is a PR targeting the v1 branch with the existing GH action workflows -- #1424. it does not run the "Build and Report Generation" tasks.

@alancai98 alancai98 merged commit 6103e9e into v1 Apr 11, 2024
14 checks passed
@alancai98 alancai98 mentioned this pull request Apr 11, 2024
Merged
@johnedquinn johnedquinn deleted the fix-v1-branch-gh-build branch April 11, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnedquinn johnedquinn johnedquinn approved these changes

Assignees

@alancai98 alancai98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alancai98 @johnedquinn